[libusb] [PATCH libusb usbdk] Align error code handling with WinUsb

[Sameeh Jubran]

WinUsb uses ERROR_GEN_FAILURE instead of ERROR_FUNCTION_FAILED,
this diffrence was observed while using Libusb's xusb example
application while alternating backends.

Signed-off-by: Sameeh Jubran <***@daynix.com>
---
libusb/os/windows_usbdk.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/libusb/os/windows_usbdk.c b/libusb/os/windows_usbdk.c
index a588e51..2bf5bfa 100644
--- a/libusb/os/windows_usbdk.c
+++ b/libusb/os/windows_usbdk.c
@@ -799,16 +799,12 @@ static DWORD usbdk_translate_usbd_status(USBD_STATUS UsbdStatus)
return NO_ERROR;

switch (UsbdStatus) {
- case USBD_STATUS_STALL_PID:
- case USBD_STATUS_ENDPOINT_HALTED:
- case USBD_STATUS_BAD_START_FRAME:
- return ERROR_GEN_FAILURE;
case USBD_STATUS_TIMEOUT:
return ERROR_SEM_TIMEOUT;
case USBD_STATUS_CANCELED:
return ERROR_OPERATION_ABORTED;
default:
- return ERROR_FUNCTION_FAILED;
+ return ERROR_GEN_FAILURE;
}
}

[Sameeh Jubran]

Ping.

Post by Sameeh Jubran
WinUsb uses ERROR_GEN_FAILURE instead of ERROR_FUNCTION_FAILED,
this diffrence was observed while using Libusb's xusb example
application while alternating backends.
---
libusb/os/windows_usbdk.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libusb/os/windows_usbdk.c b/libusb/os/windows_usbdk.c
index a588e51..2bf5bfa 100644
--- a/libusb/os/windows_usbdk.c
+++ b/libusb/os/windows_usbdk.c
@@ -799,16 +799,12 @@ static DWORD usbdk_translate_usbd_status(USBD_STATUS UsbdStatus)
return NO_ERROR;
switch (UsbdStatus) {
- return ERROR_GEN_FAILURE;
return ERROR_SEM_TIMEOUT;
return ERROR_OPERATION_ABORTED;
- return ERROR_FUNCTION_FAILED;
+ return ERROR_GEN_FAILURE;
}
}
--
2.7.4

[Sameeh Jubran]

Hi all,

Can anyone review this patch?

Post by Sameeh Jubran
Ping.

Post by Sameeh Jubran
WinUsb uses ERROR_GEN_FAILURE instead of ERROR_FUNCTION_FAILED,
this diffrence was observed while using Libusb's xusb example
application while alternating backends.
---
libusb/os/windows_usbdk.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libusb/os/windows_usbdk.c b/libusb/os/windows_usbdk.c
index a588e51..2bf5bfa 100644
--- a/libusb/os/windows_usbdk.c
+++ b/libusb/os/windows_usbdk.c
@@ -799,16 +799,12 @@ static DWORD usbdk_translate_usbd_status(USBD_STATUS UsbdStatus)
return NO_ERROR;
switch (UsbdStatus) {
- return ERROR_GEN_FAILURE;
return ERROR_SEM_TIMEOUT;
return ERROR_OPERATION_ABORTED;
- return ERROR_FUNCTION_FAILED;
+ return ERROR_GEN_FAILURE;
}
}
--
2.7.4

--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*